Use upstream d3-sankey and d3-sankey-circular dependencies#7696
Use upstream d3-sankey and d3-sankey-circular dependencies#7696adamreeve wants to merge 2 commits intoplotly:masterfrom
Conversation
There was a problem hiding this comment.
This looks like a regression that might block being able to use the upstream d3-sankey directly for now.
There was a problem hiding this comment.
Any idea what might be causing the issue?
There was a problem hiding this comment.
No, I'm not that familiar with the internals of the library. I can look into this but it might take a while as I don't have a lot of time to spend on this at the moment.
There was a problem hiding this comment.
No rush. If/when this PR is ready for review, let us know and we'll take a look.
There was a problem hiding this comment.
I've made an upstream issue at d3/d3-sankey#131 that describes the problem, will see if that gets a response. We may need to keep the forked version but update it and fix the padding behaviour.
2 participants
Fixes #7689